New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log console output during replay to file #985

Closed
abitmore opened this Issue May 28, 2018 · 21 comments

Comments

@abitmore
Member

abitmore commented May 28, 2018

User Story
As a node admin I want console output during replay be saved to log files according to logging configurations in config.ini or logging.ini, so that later diagnosis would be easier.

CORE TEAM TASK LIST

  • Evaluate / Prioritize Feature Request
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
    • Assigned: @cogutvalera
    • Estimated: 2 hours
    • Remitted: Week 39
  • Perform QA/Testing
  • Update Documentation
@cogutvalera

This comment has been minimized.

Member

cogutvalera commented Sep 10, 2018

@ryanRfox I want to claim this issue.

Thanks !

@ryanRfox

This comment has been minimized.

Member

ryanRfox commented Sep 10, 2018

I've assigned @cogutvalera for this issue. Please provide an estimate prior to developing the solution. We want @bitshares/core-dev to review.

@ryanRfox ryanRfox removed this from New -Awaiting Core Team Evaluation in Project Backlog Sep 10, 2018

@ryanRfox ryanRfox added this to In Development in Community Claims Sep 10, 2018

@cogutvalera

This comment has been minimized.

Member

cogutvalera commented Sep 11, 2018

@ryanRfox my estimation for this issue is approximately 2 hours

@cogutvalera

This comment has been minimized.

Member

cogutvalera commented Sep 14, 2018

@abitmore

  1. Maybe I've missed something but let me ask: do you mean logging.ini instead of config.ini ? right ?
  2. Can you paste here please (when you will have enough time for this) a example snippet copied from console log during replay that we need to log into file ?

Trying to understand more clearly the issue.

Thanks !

@abitmore

This comment has been minimized.

Member

abitmore commented Sep 14, 2018

No matter config.ini or logging.ini (when this issue is created there was no logging.ini).

@cogutvalera

This comment has been minimized.

Member

cogutvalera commented Sep 14, 2018

Thank you ! Just wanted to clarify some details for myself so I get the idea correctly enough.

@cogutvalera

This comment has been minimized.

Member

cogutvalera commented Sep 17, 2018

PR is ready just for bitshares-fc repo bitshares/bitshares-fc#76

@pmconrad

This comment has been minimized.

pmconrad commented Sep 19, 2018

IMO the FC change is not sufficient to fix this ticket. There's a lot of stuff "logged" via cout/cerr (for some of it that's ok though).

@cogutvalera

This comment has been minimized.

Member

cogutvalera commented Sep 19, 2018

Do not we have to create another new issue to avoid all stuff "logged" via cout/cerr ? So that we will have all stuff logged in the same manner according logging configuration. Or we don't need it ?

@pmconrad

This comment has been minimized.

pmconrad commented Sep 19, 2018

I always understood this ticket to be about cout/cerr. Didn't even know there was a problem with file_appender. :-)

@abitmore

This comment has been minimized.

Member

abitmore commented Sep 19, 2018

I don't have an opinion about cout/cerr, perhaps some of them are intended, perhaps not. Yes we can create an issue to check all of them.

@pmconrad

This comment has been minimized.

pmconrad commented Sep 21, 2018

I would like to see the replay percentage in the logs.

@cogutvalera

This comment has been minimized.

Member

cogutvalera commented Sep 21, 2018

would like to see the replay percentage in the logs.

For this we need to change in database::reindex log instruction with std::cerr to call ilog

@cogutvalera

This comment has been minimized.

Member

cogutvalera commented Sep 21, 2018

it must be done in #1289 issue, I will commit it there

@cogutvalera

This comment has been minimized.

Member

cogutvalera commented Sep 21, 2018

I would like to see the replay percentage in the logs.

is done in PR #1335 by next commit 83a66c8

@pmconrad

This comment has been minimized.

pmconrad commented Oct 1, 2018

Merged bitshares/bitshares-fc#76, please bump fc.
There are a few uses of std::cerr in application.cpp and in witness plugin that might be better placed in a logfile, please check.

@cogutvalera

This comment has been minimized.

Member

cogutvalera commented Oct 1, 2018

@pmconrad fc bumped

@abitmore abitmore added this to To do in Feature release (201810) via automation Oct 1, 2018

@abitmore abitmore moved this from To do to In progress in Feature release (201810) Oct 1, 2018

pmconrad added a commit that referenced this issue Oct 2, 2018

Merge pull request #1355 from cogutvalera/issue_985
Log console output during replay to file #985
@cogutvalera

This comment has been minimized.

Member

cogutvalera commented Oct 3, 2018

we can close this issue because both PRs #1355 / bitshares/bitshares-fc#76 are merged already

@cogutvalera

This comment has been minimized.

Member

cogutvalera commented Oct 3, 2018

Thanks !

@pmconrad

This comment has been minimized.

pmconrad commented Oct 3, 2018

Yep. Thanks for the reminder.

@pmconrad pmconrad closed this Oct 3, 2018

Feature release (201810) automation moved this from In progress to Done Oct 3, 2018

@cogutvalera

This comment has been minimized.

Member

cogutvalera commented Oct 3, 2018

Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment