Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing add cli_test to travis #1156

Merged
merged 2 commits into from Jul 21, 2018
Merged

testing add cli_test to travis #1156

merged 2 commits into from Jul 21, 2018

Conversation

oxarbitrage
Copy link
Member

for #1152

@oxarbitrage
Copy link
Member Author

oxarbitrage commented Jul 18, 2018 •
edited

working. https://travis-ci.org/bitshares/bitshares-core/builds/405505692?utm_source=github_status&utm_medium=notification

pmconrad
pmconrad approved these changes Jul 19, 2018
View reviewed changes
Copy link
Contributor

@pmconrad pmconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
(Docker build failing with internal server error, whatever that means...)

@oxarbitrage
Copy link
Member Author

i clicked a retry in docker and after long hours it end up building https://cloud.docker.com/swarm/bitshares/repository/registry-1.docker.io/bitshares/bitshares-core/builds/75763d4e-459b-4f9f-9787-e38a351577a5

it will still show as failed here but i think is safe to merge.

@oxarbitrage oxarbitrage merged commit 7a5828a into develop Jul 21, 2018
@oxarbitrage oxarbitrage mentioned this pull request Jul 21, 2018
Closed
2 tasks
@abitmore abitmore added this to In Development in Feature Release (201808) via automation Jul 21, 2018
@abitmore abitmore deleted the oxarbitrage-patch-6 branch July 21, 2018 00:33
@abitmore abitmore moved this from In Development to Done in Feature Release (201808) Jul 21, 2018
@abitmore abitmore mentioned this pull request Aug 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmconrad pmconrad pmconrad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Feature Release (201808)
  
Done
Milestone
201808 - Non-Consensus-Changing Release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oxarbitrage @pmconrad @abitmore