New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove not needed budget_record_object creation from maint #1213

Merged
merged 3 commits into from Sep 5, 2018

Conversation

Projects
3 participants
@oxarbitrage
Member

oxarbitrage commented Jul 31, 2018

for issue #1139

chain tests all passing, replayed a few months of the chain without any issue.

@abitmore abitmore added this to In progress in Feature release (201810) via automation Jul 31, 2018

_rec.record = rec;
});

This comment has been minimized.

@abitmore

abitmore Aug 13, 2018

Member

Please change this line to a real empty line.

@pmconrad

pmconrad requested changes Aug 14, 2018 edited

IMO either delete old budget_record_objects to release the space, or remove budget_record_object completely from the code, not only the create<> operation.
Creating + later deleting them would enable plugins to do something with the information (think es_objects). OTOH I think it's unlikely that anyone is using this information, so removing it completely shouldn't hurt.

@oxarbitrage oxarbitrage self-assigned this Aug 24, 2018

@oxarbitrage

This comment has been minimized.

Member

oxarbitrage commented Aug 24, 2018

removed budget_record_object completely as suggested at #1213 (review)

cant remove budget_record_object.hpp as the budget_record struct is needed.

we can maybe change the name of that file to just budget_record.hpp or move the struct somewhere else.

@pmconrad

This comment has been minimized.

pmconrad commented Aug 27, 2018

Can move the declaration of struct budget_record into db_maint.cpp, since it's only used internally.

Feature release (201810) automation moved this from In progress to In Testing Sep 5, 2018

@abitmore abitmore merged commit 2a175e6 into bitshares:develop Sep 5, 2018

2 checks passed

ci/dockercloud Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Feature release (201810) automation moved this from In Testing to Done Sep 5, 2018

@oxarbitrage oxarbitrage referenced this pull request Nov 17, 2018

Merged

Reverse #1213 #1438

oxarbitrage added a commit that referenced this pull request Nov 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment