Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing FC Typenames (Issue #1217) #1248

Merged
merged 4 commits into from Aug 17, 2018

Conversation

Projects
3 participants
@jmjatlanta
Copy link
Contributor

commented Aug 11, 2018

This is the core portion of #1217, and works with PR bitshares/bitshares-fc#74

Prior get_typename was generating classes on many unnecessary classes. This modification correctly generates code for only the classes necessary.

@pmconrad

This comment has been minimized.

Copy link
Contributor

commented Aug 11, 2018

Note: waiting for fc bump

@abitmore abitmore added this to In progress in Feature release (201810) via automation Aug 11, 2018

static const char* name()
{
return (std::string("graphene::chain::extension<")
+ fc::get_typename<T>::name() + std::string(">")).c_str();

This comment has been minimized.

Copy link
@abitmore

abitmore Aug 11, 2018

Member

Need to change to static n here as well?

This comment has been minimized.

Copy link
@jmjatlanta

jmjatlanta Aug 13, 2018

Author Contributor

Yes. Done. Thanks.

@jmjatlanta

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2018

I'm happy to bump FC as part of this ticket. Is that the way it should be done, or in a separate PR? Thanks.

@abitmore

This comment has been minimized.

Copy link
Member

commented Aug 13, 2018

... bump FC as part of this ticket. Is that the way it should be done ..

Yes.

@pmconrad

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2018

I think that needs a stronger bump. :-)

@pmconrad

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2018

Note: this includes the fix for #1244

Feature release (201810) automation moved this from In progress to In Testing Aug 17, 2018

@abitmore abitmore merged commit e665b60 into develop Aug 17, 2018

3 checks passed

ci/dockercloud Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

Feature release (201810) automation moved this from In Testing to Done Aug 17, 2018

@abitmore abitmore deleted the jmj_issue_1271 branch Aug 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.