Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #584 authorize transactions with non-immediate owner authorities #1259

Merged
merged 11 commits into from Feb 10, 2019

Conversation

Projects
5 participants
@abitmore
Copy link
Member

commented Aug 16, 2018

PR for #584.

Todo:

  • add test cases for APIs;
  • rebase after merged #1255;
    • fix test cases added in #1255
      - [ ] update proposal tests after implemented #278. update: moved this job to #278.
  • fix code added in #1384
    - [ ] fix test cases after #1360 is merged
    - [ ] fix code after #1401 is merged
@abitmore

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2018

Rebased to latest develop branch to resolve conflicts.

@abitmore abitmore added this to In Development in Protocol Upgrade Release (3.0.0) Sep 13, 2018

@pmconrad
Copy link
Contributor

left a comment

Looks good, thanks!

Protocol Upgrade Release (3.0.0) automation moved this from In Development to In Testing Sep 14, 2018

@pmconrad pmconrad force-pushed the 584-non-immediate-owner branch from 0592ce3 to ac310b1 Jan 29, 2019

Protocol Upgrade Release (3.0.0) automation moved this from In Testing to In Development Jan 29, 2019

@pmconrad

This comment has been minimized.

Copy link
Contributor

commented Jan 29, 2019

Rebased on latest hardfork to resolve merge conflict

@pmconrad pmconrad requested a review from oxarbitrage Jan 29, 2019

@pmconrad pmconrad moved this from In Development to In Testing in Protocol Upgrade Release (3.0.0) Jan 30, 2019

@abitmore

This comment has been minimized.

Copy link
Member Author

commented Feb 5, 2019

@jmjatlanta, @oxarbitrage or @xeroc please review this so we can merge it? Because both I and Peter have pushed some code, it's best that another developer can review it.

@abitmore abitmore requested a review from jmjatlanta Feb 5, 2019

@abitmore abitmore requested a review from xeroc Feb 5, 2019

@jmjatlanta
Copy link
Contributor

left a comment

Looks good. Tested on Ubuntu 18.10.

@oxarbitrage

This comment has been minimized.

Copy link
Member

commented Feb 5, 2019

i will want to take a look tomorrow after the feature release is done. thank you.

Protocol Upgrade Release (3.0.0) automation moved this from In Review to In Development Feb 6, 2019

Protocol Upgrade Release (3.0.0) automation moved this from In Development to In Review Feb 8, 2019

@oxarbitrage
Copy link
Member

left a comment

looks good to me, great work, thanks.

@pmconrad pmconrad merged commit c042e68 into hardfork Feb 10, 2019

2 of 3 checks passed

ci/dockercloud Your tests failed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

Protocol Upgrade Release (3.0.0) automation moved this from In Review to Done Feb 10, 2019

@pmconrad pmconrad deleted the 584-non-immediate-owner branch Feb 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.