New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsigned_int unpacking #1267

merged 3 commits into from Aug 23, 2018


2 participants

pmconrad commented Aug 19, 2018

Resolves #993 and #1088.


@@ -122,7 +122,6 @@ template<> struct js_name<fc::uint160> { static std::string name(){ retu
template<> struct js_name<fc::sha224> { static std::string name(){ return "bytes 28"; } };
template<> struct js_name<fc::sha256> { static std::string name(){ return "bytes 32"; } };
template<> struct js_name<fc::unsigned_int> { static std::string name(){ return "varuint32"; } };
template<> struct js_name<fc::signed_int> { static std::string name(){ return "varint32"; } };

This comment has been minimized.


abitmore Aug 19, 2018


Actually JS code is using varint32 everywhere but not varuint32. Will submit an issue there.

This comment has been minimized.


pmconrad Aug 19, 2018

Hm, should we rename that to varuint64?

This comment has been minimized.


abitmore Aug 19, 2018


Yes, I think so.
JS code need to be fixed anyway.


This comment has been minimized.


abitmore commented Aug 19, 2018

[ 93%] Building CXX object libraries/plugins/elasticsearch/CMakeFiles/graphene_elasticsearch.dir/elasticsearch_plugin.o
Broadcast message from root@travis-job-2cd07e9d-7fb4-490c-8b3e-31a13c875a31
	(unknown) at 22:14 ...
The system is going down for power off NOW!
[ 94%] Linking CXX static library libgraphene_witness.a


pmconrad added some commits Aug 20, 2018

@abitmore abitmore added this to In progress in Feature release (201810) via automation Aug 23, 2018

Feature release (201810) automation moved this from In progress to In Testing Aug 23, 2018

@abitmore abitmore merged commit d382ac8 into develop Aug 23, 2018

3 checks passed

ci/dockercloud Your tests passed in Docker Cloud
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

Feature release (201810) automation moved this from In Testing to Done Aug 23, 2018

@abitmore abitmore deleted the 993_un_signed_int_unpacking branch Aug 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment