Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating cURL into cmake #1336

Merged
merged 5 commits into from Oct 8, 2018

Conversation

Projects
5 participants
@abitmore
Copy link
Member

commented Sep 20, 2018

The original PR is #1329, will continue the work in this PR.

Todo:

cwyyprog and others added some commits Aug 23, 2018

Merge pull request #1329 from cwyyprog/cURL
Integrating cURL into cmake

@abitmore abitmore added this to the 201810 - Feature Release milestone Sep 20, 2018

@abitmore abitmore added this to In progress in Feature release (201810) via automation Sep 20, 2018

@ryanRfox

This comment has been minimized.

Copy link
Member

commented Sep 25, 2018

@jmjatlanta Do you have time and an environment to test this?

@jmjatlanta

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2018

I have a macOS and Ubuntu 18.04 environment. I need to take a longer look at my Windows VM and figure out why I can't build there. It has never worked (seems to be something fishy with cmake's findBoost.cmake). I will attack mac and linux first, and then see what I can do for Windows.

Feature release (201810) automation moved this from In progress to In Testing Sep 28, 2018

@jmjatlanta
Copy link
Contributor

left a comment

Windows: Using the instructions at WinDevEnv I built the develop branch. It failed due to not finding the header file curl.h. I then checked out the curl-cmake branch and built it without errors.

I then tested the curl-cmake branch on Ubuntu 18.04. It also built without errors.

@oxarbitrage

This comment has been minimized.

@oxarbitrage oxarbitrage self-requested a review Oct 3, 2018

@oxarbitrage

This comment has been minimized.

Copy link
Member

commented Oct 3, 2018

@oxarbitrage
Copy link
Member

left a comment

elasticsearch plugins working ok with this changes from linux.

Feature release (201810) automation moved this from In Testing to Done Oct 8, 2018

@oxarbitrage oxarbitrage merged commit 42e2342 into develop Oct 8, 2018

3 checks passed

ci/dockercloud Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@abitmore abitmore deleted the curl-cmake branch Feb 5, 2019

@abitmore abitmore restored the curl-cmake branch Feb 5, 2019

@abitmore abitmore deleted the curl-cmake branch Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.