New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add performance test #1337

Merged
merged 6 commits into from Sep 30, 2018

Conversation

Projects
5 participants
@pmconrad

pmconrad commented Sep 23, 2018

This is a test case for the famous "100,000 transactions per second", referred to in my presentation at BitFest.

@oxarbitrage oxarbitrage self-requested a review Sep 27, 2018

@oxarbitrage oxarbitrage added this to the 201810 - Feature Release milestone Sep 28, 2018

@oxarbitrage

excellent work that really shows the limits of the technology being used in bitshares, first time actually seeing with my own eyes. i made some small comments that you will maybe want to take a look but they are not strong enough to delay my aprove. thank you for this work.

Show resolved Hide resolved tests/performance/performance_tests.cpp
Show resolved Hide resolved tests/performance/performance_tests.cpp

@abitmore abitmore added this to In progress in Feature release (201810) via automation Sep 28, 2018

@abitmore

This comment has been minimized.

Member

abitmore commented Sep 28, 2018

Good job. We'd better update Wiki after merged this.

@abitmore abitmore moved this from In progress to In Testing in Feature release (201810) Sep 28, 2018

@cogutvalera

Well done ! Nice job ! Please add new empty lines at the end of both files performance_tests & database_fixture

Thanks !

@cogutvalera

cogutvalera suggested changes Sep 29, 2018 edited

Looking other details also before we merged this ...

Awesome test ! Thank you very much !

Feature release (201810) automation moved this from In Testing to In progress Sep 29, 2018

@pmconrad

This comment has been minimized.

pmconrad commented Sep 29, 2018

Please add new empty lines at the end of both files performance_tests & database_fixture

The last lines have proper endings, no need for an additional empty line.

@abitmore

This comment has been minimized.

Member

abitmore commented Sep 29, 2018

Better wrap long lines.

@cogutvalera

Thanks ! Great !

@pmconrad

This comment has been minimized.

pmconrad commented Sep 30, 2018

@oxarbitrage please re-review, your review got dismissed automatically. :-/

@oxarbitrage

sorry about that re approving.

Feature release (201810) automation moved this from In progress to In Testing Sep 30, 2018

@pmconrad pmconrad merged commit 1d2c5f8 into bitshares:develop Sep 30, 2018

2 checks passed

ci/dockercloud Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Feature release (201810) automation moved this from In Testing to Done Sep 30, 2018

@pmconrad

This comment has been minimized.

pmconrad commented Sep 30, 2018

@cedar-book can you please add a link to https://github.com/bitshares/bitshares-core/tree/develop/tests/performance in the documentation? Perhaps next to my bitfest presentation download. Not sure if there's another page dealing with performance.
Thanks!

@cedar-book

This comment has been minimized.

cedar-book commented Oct 3, 2018

@pmconrad , I added the link to two locations.

(1) BitShares Community Events
http://dev.bitshares.works/en/master/references/info_bts_events.html

(2) Developer Guide (Tutorials) - Performance section
http://dev.bitshares.works/en/master/bts_guide/tutorials/index.html#performance

@pmconrad

This comment has been minimized.

pmconrad commented Oct 4, 2018

Excellent, thanks!

@pmconrad pmconrad deleted the pmconrad:performance_test branch Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment