New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More 32 bit to 64 bit changes #1347

Merged
merged 6 commits into from Oct 10, 2018

Conversation

Projects
3 participants
@jmjatlanta

jmjatlanta commented Sep 28, 2018

Fixes #1206

There are 32 bit variables all throughout the code. Each one could stand to be reviewed (over 2000 by my count). This PR takes care of a few that were being used as counters that could overflow.

Blindly converting all 32 bit values to 64 bit is not advisable. Neither is attempting to review every 32 bit variable within 1 github issue. This PR takes care of the few that were found in issue #1206.

@abitmore

We need to bump db_version.

@abitmore abitmore added this to the 201810 - Feature Release milestone Oct 1, 2018

@abitmore abitmore added this to In progress in Feature release (201810) via automation Oct 1, 2018

@abitmore abitmore removed this from In progress in Feature release (201810) Oct 1, 2018

@abitmore abitmore added this to In progress in Feature Release (201812) via automation Oct 1, 2018

jmjatlanta added some commits Oct 9, 2018

Feature Release (201812) automation moved this from In progress to Reviewer approved Oct 9, 2018

@abitmore

This comment has been minimized.

Member

abitmore commented Oct 9, 2018

Perhaps we can include this in 201810 release? BTW I'd like to keep the issue open for future findings even after merged this. Thoughts?

@abitmore abitmore added this to In progress in Feature release (201810) via automation Oct 9, 2018

@abitmore abitmore removed this from Reviewer approved in Feature Release (201812) Oct 9, 2018

@abitmore abitmore moved this from In progress to In Testing in Feature release (201810) Oct 9, 2018

@pmconrad pmconrad merged commit c13d7c3 into develop Oct 10, 2018

2 checks passed

ci/dockercloud Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

Feature release (201810) automation moved this from In Testing to Done Oct 10, 2018

@pmconrad

This comment has been minimized.

pmconrad commented Oct 10, 2018

Agree about keeping the issue open.

@pmconrad pmconrad deleted the jmj_1206 branch Oct 10, 2018

abitmore added a commit that referenced this pull request Oct 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment