New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change comment #1349

Merged
merged 2 commits into from Sep 29, 2018

Conversation

Projects
2 participants
@oxarbitrage
Member

oxarbitrage commented Sep 28, 2018

@@ -116,9 +116,10 @@ void database::update_last_irreversible_block()
static_assert( GRAPHENE_IRREVERSIBLE_THRESHOLD > 0, "irreversible threshold must be nonzero" );
// 1 1 1 2 2 2 2 2 2 2 -> 2 .7*10 = 7
// 1 1 1 2 2 2 2 2 2 2 -> 1 .3*10 = 3

This comment has been minimized.

@pmconrad

pmconrad Sep 29, 2018

The result "2" was correct - offset is 0-based, so it's the 4th element.

This comment has been minimized.

@oxarbitrage

oxarbitrage Sep 29, 2018

Member

changed, thanks.

@oxarbitrage oxarbitrage added this to the 201810 - Feature Release milestone Sep 29, 2018

@pmconrad

Thanks!

@pmconrad pmconrad merged commit 30f93cf into develop Sep 29, 2018

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
ci/dockercloud Your tests are pending in Docker Cloud
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@abitmore abitmore added this to In progress in Feature release (201810) via automation Sep 29, 2018

@abitmore abitmore moved this from In progress to Done in Feature release (201810) Sep 29, 2018

@abitmore abitmore deleted the oxarbitrage-patch-1 branch Oct 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment