Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change description of delayed_node option #1410

Merged
merged 1 commit into from Dec 14, 2018

Conversation

Projects
4 participants
@HarukaMa
Copy link
Contributor

commented Oct 30, 2018

It seems that witness_node will populate all possible options to config.ini from all available nodes in new data dir, and the description of trusted-node for delayed node is a bit confusing.

It looks like:

# Will only store matched orders in last X seconds...
max-order-his-seconds-per-market = 2592000

# RPC endpoint of a trusted validating node (required)
# trusted-node =

# Block number after which to do a snapshot
# snapshot-at-block =

while it's not required for a normal node.

Maybe we should not merge this, instead prepend the name of plugin before corresponding options to clarify this (#1407).

@HarukaMa HarukaMa referenced this pull request Oct 30, 2018

Closed

Add plugin section headers for auto-generated config.ini #1407

1 of 17 tasks complete
@pmconrad
Copy link
Contributor

left a comment

Thanks.
I think we should accept the change for now, until we have a better solution for #1407

@oxarbitrage

This comment has been minimized.

Copy link
Member

commented Oct 31, 2018

Please hold this merge, i am working in a solution for #1407 . Not very elegant but we can discuss it. Pull request for it coming in the next hours.

@HarukaMa

This comment has been minimized.

Copy link
Contributor Author

commented Nov 27, 2018

As #1411 would still take some time to come out, maybe this one should be merged first? I've seen another report of confusing comment in dev group just now...

@oxarbitrage
Copy link
Member

left a comment

I agree, the final solution was a lot harder than expected and this at least will avoid some confusion.

@pmconrad pmconrad merged commit 1fc6dc1 into bitshares:develop Dec 14, 2018

2 checks passed

ci/dockercloud Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@abitmore abitmore added this to the 201901 - Feature Release milestone Jan 1, 2019

@abitmore abitmore added this to In progress in Feature Release (201902) via automation Jan 1, 2019

@abitmore abitmore moved this from In progress to Done in Feature Release (201902) Jan 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.