Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build errors and a warning #1421

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
2 participants
@nathanhourt
Copy link
Contributor

commented Nov 7, 2018

  • Fix warning that using std::move on a temporary value prevents copy elision
  • Add missing FC_REFLECT_TYPENAME on account operation extensions
  • Replace deprecated call to fc::rand_pseudo_bytes with
    fc::rand_bytes.
  • Include smart_ref_impl.hpp in fork_database.cpp which is required for build on some configurations

nathanhourt added some commits Nov 2, 2018

Fix warning
Potential optimization: don't move a temporary as this prevents
copy elision
Fix build errors
 - Add missing FC_REFLECT_TYPENAME on account operation extentions
 - Replace deprecated call to fc::rand_pseudo_bytes with
fc::rand_bytes.
Include smart_ref_impl from fork_database.cpp
Required for build on some configurations
@nathanhourt

This comment has been minimized.

Copy link
Contributor Author

commented Nov 7, 2018

Hmm, that travis failure makes no sense to me. I'm not sure how 67ccc53 could cause that failure, could the travis tests be unstable?

@oxarbitrage

This comment has been minimized.

Copy link
Member

commented Nov 7, 2018

Hmm, that travis failure makes no sense to me. I'm not sure how 67ccc53 could cause that failure, could the travis tests be unstable?

Just restarted travis build for this as yes, sometimes the cli_tests fails and we dont know the exact reason. Lets see how it goes now.

@oxarbitrage
Copy link
Member

left a comment

nice work, thanks.

@oxarbitrage oxarbitrage changed the base branch from master to develop Nov 9, 2018

@oxarbitrage oxarbitrage changed the base branch from develop to master Nov 9, 2018

@oxarbitrage

This comment has been minimized.

Copy link
Member

commented Nov 9, 2018

sorry, i didn't saw here the pull is against master. You need to send to develop branch. Can you do it ? If not i can do it for you.

@oxarbitrage

This comment has been minimized.

Copy link
Member

commented Nov 9, 2018

moved to #1426

@oxarbitrage oxarbitrage closed this Nov 9, 2018

@nathanhourt nathanhourt deleted the nathanhourt:patch-0 branch Nov 9, 2018

oxarbitrage added a commit that referenced this pull request Nov 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.