Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build errors - replaces #1421 #1426

merged 3 commits into from Nov 10, 2018


4 participants
Copy link

commented Nov 9, 2018

cherry pick the 2 commits in #1421 by @nathanhourt as we need the changes in develop branch.

nathanhourt added some commits Nov 2, 2018

Fix warning
Potential optimization: don't move a temporary as this prevents
copy elision
Fix build errors
 - Add missing FC_REFLECT_TYPENAME on account operation extentions
 - Replace deprecated call to fc::rand_pseudo_bytes with
Include smart_ref_impl from fork_database.cpp
Required for build on some configurations

This comment has been minimized.

Copy link

commented Nov 9, 2018

Oops, my bad. I'll PR to develop in the future :)

Copy link

left a comment

Looks good. Thanks!

@oxarbitrage oxarbitrage merged commit 32d8d08 into bitshares:develop Nov 10, 2018

2 checks passed

ci/dockercloud Your tests passed in Docker Cloud
continuous-integration/travis-ci/pr The Travis CI build passed

@abitmore abitmore added this to the 201901 - Feature Release milestone Jan 1, 2019

@abitmore abitmore added this to In progress in Feature Release (201902) via automation Jan 1, 2019

@abitmore abitmore moved this from In progress to Done in Feature Release (201902) Jan 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.