Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
move --plugins from application to binary #1427 #1437
I am sorry to have to open a new pull request for this ...
This will at least remove the hardcoded plugins from the application.
I was not able to use
Another thing changed is
Let me know what do you guys think as if we go with this approach i will need to do something similar in delayed node.
A few things i also noticed while working on this and related are, probably to consider as new issues:
IMO the current behaviour is reasonable. The config file contains the usual defaults, and the option given on the command line overrides the config file.
In a branch i have handy here based on
I didn't know the issue was unrelated to the changes done here until now.
So i did it the way the
The delayed node haves several issues that are unrelated to the scope of this pull request, for example:
in this patch output will be:
in unpatched node:
with this pull:
version without patch:
Much of this is unrelated to the scope of this pull(which is already pretty big) so we better treat them somewhere else as you suggested, the important thing to me is that now the delayed node binary of this pull works the same(with the same problems) as the delayed node before.
There is another case where the unpatched version was working ok while the patched failing.
It is the case when
With 1326a5c both versions will do the same. For example user will want to load delayed node and market history plugin leaving account history out, he can do that now in the patched version.
These changes look good. I see one comment above that I am unsure that it has been handled. Perhaps it has, but I do not see it.
If it has been handled, great. If not, what would be the expected behavior? An exception stating that the function is not available? Or perhaps you cannot even get a pointer to that API to be able to call that function?