Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for errors while loading object_database #1461

Merged
merged 2 commits into from Dec 4, 2018

Conversation

Projects
3 participants
@pmconrad
Copy link
Contributor

commented Dec 3, 2018

Errors while reading object_database were silently ignored, which could lead to an incomplete or inconsistent database after restart. Now, exceptions are no longer caught and will trigger application abort.

Also includes a fix for a minor efficiency in an API call.

@oxarbitrage

This comment has been minimized.

Copy link
Member

commented Dec 4, 2018

I was not able to make the travis build pass so i am building it manually ... will update in a bit.

@oxarbitrage
Copy link
Member

left a comment

code looks good, all tests passing. thanks.

@pmconrad pmconrad merged commit 91eb971 into develop Dec 4, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@pmconrad pmconrad deleted the fixes branch Dec 4, 2018

@pmconrad pmconrad added this to In progress in Feature Release (201902) via automation Dec 4, 2018

@pmconrad pmconrad added this to the 201812 - Feature Release milestone Dec 4, 2018

@abitmore abitmore moved this from In progress to Done in Feature Release (201902) Dec 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.