Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
add support for existing tests after hf1270 #1493
By comments in #1324 (comment) the flag for existing tests was added to database fixture.
This pull is not to merge(at least not as it is) but it is for discussion of some issues found in the existing tests after the hardfork.
Trying to give support for the following existing test cases:
The first 3 tests pass after hardfork, only mod needed is on
In the last 2 there are some different at matching orders, specifically i modified a bit
This is how before HF match the orders before and after the big sell order:
And this is what after HF will do:
@abitmore i will like to have your word about this when you can.
before HF call orders:
I added after hf1270 tests to
There is an issue with order matching in 1 of them, at
The rest of them seems to be ok. @abitmore let me know what do you think about this one when you can.
added this to In Development
in Protocol Upgrade Release (3.0.0)
Jan 16, 2019
By the way, similar code added in previous PR need to be updated as well, E.G.
and also mcr_bug_increase_after1270, mcr_bug_decrease_before1270 and mcr_bug_decrease_after1270.
To be more accurate, should generate blocks until the maintenance time but not the hf time.
Actually, theoretically some test cases will fail if hf453 and hf1270 happen in the same maintenance interval (in reality we know they aren't, so it's fine).
In this commit: 8466e19 i removed that test and use the spot to test hardfork 1270. I am unsure if it is the right thing to do, can revert back.
The logic around