Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check max_supply before borrowing MPAs #1498

Merged
merged 9 commits into from Jan 25, 2019

Conversation

Projects
4 participants
@jmjatlanta
Copy link
Contributor

commented Dec 27, 2018

Fixes #1465

jmjatlanta added some commits Dec 27, 2018

@pmconrad
Copy link
Contributor

left a comment

What about existing MPAs and their max_supply?
I think we need hardfork protection on the new FC_ASSERT and some logic to adapt max_supply of existing bitAssets at hardfork time, if necessary.

@jmjatlanta

This comment has been minimized.

Copy link
Contributor Author

commented Dec 31, 2018

and some logic to adapt max_supply of existing bitAssets at hardfork time, if necessary.

How do you see this working? My thought: At the hardfork, flip through all bitAssets, if current supply is greater than max supply, adjust max supply to equal current supply. What if that number is greater than GRAPHENE_MAX_SHARE_SUPPLY?

@pmconrad

This comment has been minimized.

Copy link
Contributor

commented Jan 2, 2019

Shouldn't happen due to softfork protection. If it does happen set max_supply to GRAPHENE_MAX_SHARE_SUPPLY.

@pmconrad

This comment has been minimized.

Copy link
Contributor

commented Jan 8, 2019

Test still failing because after generate_blocks, alice is no longer a valid reference (in line 2057).

@jmjatlanta

This comment has been minimized.

Copy link
Contributor Author

commented Jan 8, 2019

Test still failing because after generate_blocks, alice is no longer a valid reference (in line 2057).

Gee wiz. It passed for me. The problem must be on your end! :-D

Fixed reference, tested in Ubuntu 18.10 in both Debug and Release mode.

Hardfork protection added

@abitmore abitmore added this to In Development in Protocol Upgrade Release (3.0.0) via automation Jan 16, 2019

Protocol Upgrade Release (3.0.0) automation moved this from In Development to In Testing Jan 17, 2019

@pmconrad
Copy link
Contributor

left a comment

Thanks!

Protocol Upgrade Release (3.0.0) automation moved this from In Testing to In Development Jan 17, 2019

Show resolved Hide resolved libraries/chain/market_evaluator.cpp Outdated
@cogutvalera
Copy link
Member

left a comment

Thanks

Protocol Upgrade Release (3.0.0) automation moved this from In Development to In Testing Jan 25, 2019

@jmjatlanta jmjatlanta merged commit 0f10387 into hardfork Jan 25, 2019

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/dockercloud Your tests are pending in Docker Cloud
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

Protocol Upgrade Release (3.0.0) automation moved this from In Testing to Done Jan 25, 2019

@jmjatlanta jmjatlanta deleted the jmj_1465 branch Jan 25, 2019

@jmjatlanta jmjatlanta referenced this pull request Jan 31, 2019

Closed

Borrowing MPAs ignores max_supply setting #1465

2 of 17 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.