Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warnings #1503

Closed
wants to merge 19 commits into from

Conversation

Projects
3 participants
@jmjatlanta
Copy link
Contributor

commented Dec 28, 2018

This is a partial fix for #1246

Newer compilers throw many more warnings. These commits minimize the warnings by:

  • moving destructor implementation to the implemenation file
  • adding 2 -Wno-xxxx to the compiler options
  • fixing many signed/unsigned comparison in tests

Moving the destructor to the implementation file still causes a warning, but it is at compile of the .cpp, not each time the .hpp is included.

Adding the compiler options squelches warnings that are caused by (1) boost and (2) a non-trivial copy.

There are still warnings about destructors throwing. I believe we should be using exit() instead of throwing, if we truly want to end the program, but these are sometimes within libraries. So I am unsure of the side effects (i.e. who all are using them, even outside the project).

jmjatlanta and others added some commits Dec 25, 2018

Merge pull request #1502 from bitshares/jmj_1459
Log informational message when plugin starts
Merge pull request #1494 from bitshares/jmj_1490
Prevent exception when querying account history

@abitmore abitmore added this to the 201901 - Feature Release milestone Jan 1, 2019

@abitmore abitmore added this to In progress in Feature Release (201902) via automation Jan 1, 2019

@jmjatlanta

This comment has been minimized.

Copy link
Contributor Author

commented Jan 1, 2019

Incorrect rebase goofed PR. Closing to create new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.