Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix #782: Change hard-coded limitations in API's to configurable #1513
Added the review comments in request #1478 and test case for the api validation
This is wrt issue #782
Testcase Scenarios (Completed for PartA) :
Part B: get_account_history - Do you want me to proceed with Part2 for get_account_history to make its FC_ASSSERT configurable?
Part C: Below apis have FC_ASSERT should they be made configurable?
This was referenced
Jan 4, 2019
Feel free to continue with B and C.
Code-wise I'd say this can be merged on its own, however, I would like to see a consistent naming scheme for the option names here and in the future PRs. For example,
modified the milestones:
Future Feature Release,
Possible 201904 Feature Release
Feb 20, 2019
pmconrad left a comment
Thanks for restoring history. c0a1109 is what I originally approved I believe.
I'm confused by your later commits though. Why do you add tests only to remove them again? If that was an accident, please squash the two commits into one and force-push.
There's an unrelated API change in there, probably also by accident.
Personally I don't like some coding styles appeared in the code: tabs, long lines (>118 characters), inconsistent indentations/padding/spacing E.G. sometimes no white spaces around