Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some macOS warnings #1515

Merged
merged 6 commits into from Mar 13, 2019

Conversation

Projects
3 participants
@jmjatlanta
Copy link
Contributor

commented Jan 7, 2019

Compiling on macOS generates a good number of warnings. These commits fix the following:

  • an override of node::handle_message in application_impl that was not declared as such
  • some classes were forward declared as structs
  • some classes declared virtual methods without declaring a virtual destructor

@abitmore abitmore added this to the Future Feature Release milestone Feb 18, 2019

@abitmore abitmore added this to In development in Feature Release (3.1.0) via automation Feb 18, 2019

@abitmore

This comment has been minimized.

Copy link
Member

commented Feb 18, 2019

Why this hasn't been merged?

@jmjatlanta

This comment has been minimized.

Copy link
Contributor Author

commented Feb 18, 2019

Why this hasn't been merged?

Awaiting review.

@pmconrad pmconrad moved this from In development to In testing in Feature Release (3.1.0) Mar 5, 2019

@abitmore abitmore merged commit 5162ebe into develop Mar 13, 2019

2 of 4 checks passed

ci/dockercloud Your tests failed in Docker Cloud
Details
ci/dockercloud-stage Your tests failed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

Feature Release (3.1.0) automation moved this from In testing to Done Mar 13, 2019

@abitmore abitmore deleted the jmj_macwarn branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.