Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure price_to_string works and throws as it should #1518

Merged
merged 2 commits into from Jan 14, 2019

Conversation

Projects
3 participants
@jmjatlanta
Copy link
Contributor

commented Jan 8, 2019

Still gathering final requirements for ticket #1186. This PR is an improvement of the test, but incomplete until the details are sorted.

  • Finalize details
@pmconrad
Copy link
Contributor

left a comment

Looks good, thanks.

@jmjatlanta jmjatlanta merged commit aae2b4c into develop Jan 14, 2019

2 of 3 checks passed

ci/dockercloud Your tests failed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jmjatlanta jmjatlanta deleted the jmj_1186 branch Jan 14, 2019

@abitmore abitmore added this to the 201901 - Feature Release milestone Jan 15, 2019

@abitmore abitmore added this to In progress in Feature Release (201902) via automation Jan 15, 2019

@abitmore abitmore moved this from In progress to Done in Feature Release (201902) Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.