Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid calling exit from inside library, and removed "create-genesis-json" startup option #1529

Merged
merged 5 commits into from Jan 22, 2019

Conversation

Projects
3 participants
@jmjatlanta
Copy link
Contributor

commented Jan 14, 2019

Fixes #1110

Calling exit from inside a library makes unit testing impossible. This fix uses return values to indicate if the application should end or continue.

Show resolved Hide resolved libraries/app/application.cpp Outdated

@abitmore abitmore added this to the 201901 - Feature Release milestone Jan 14, 2019

@abitmore abitmore added this to In progress in Feature Release (201902) via automation Jan 14, 2019

@pmconrad

This comment has been minimized.

Copy link
Contributor

commented Jan 15, 2019

IMO the --create-example-genesis option does not serve a useful purpose.
Things could be simplified by creating an example genesis file somewhere in the documentation, removing that option from the code, and throwing in case of an error instead of defining and checking return codes. Return codes are error-prone, which is why exceptions were invented.

@jmjatlanta

This comment has been minimized.

Copy link
Contributor Author

commented Jan 15, 2019

IMO the --create-example-genesis option does not serve a useful purpose.

I can certainly do that. I do believe that option is part of some instructions (private testnet perhaps?), so cleaning the documentation would be required. @abitmore I would appreciate your opinion.

@abitmore

This comment has been minimized.

Copy link
Member

commented Jan 15, 2019

I prefer keeping the code if it leads to less work.

@pmconrad

This comment has been minimized.

Copy link
Contributor

commented Jan 16, 2019

Accepting this PR will be the least work of course, but IMO the end result would be better if my suggestion was implemented.

@pmconrad

This comment has been minimized.

Copy link
Contributor

commented Jan 20, 2019

Please resolve conflicts, then I'll approve.

@abitmore abitmore changed the title Avoid calling exit from inside library Avoid calling exit from inside library, and removed "create-genesis-json" startup option Jan 21, 2019

@abitmore

This comment has been minimized.

Copy link
Member

commented Jan 21, 2019

Created issue #1536 for tracking documentation work.

Feature Release (201902) automation moved this from In progress to Reviewer approved Jan 22, 2019

@pmconrad
Copy link
Contributor

left a comment

Thanks!

@jmjatlanta jmjatlanta merged commit 6669fb9 into develop Jan 22, 2019

0 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
ci/dockercloud Your tests failed in Docker Cloud
Details

Feature Release (201902) automation moved this from Reviewer approved to Done Jan 22, 2019

@jmjatlanta jmjatlanta deleted the jmj_1110 branch Jan 22, 2019

@abitmore abitmore referenced this pull request Apr 12, 2019

Open

Merge improvements from BitShares #26

4 of 24 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.