Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch uin8_t for char for clearer serialization #1535

Merged
merged 1 commit into from Jan 24, 2019

Conversation

Projects
3 participants
@jmjatlanta
Copy link
Contributor

commented Jan 18, 2019

The HTLC redeem operation took a vector of uint8_t. This worked fine, but made de-serialization output list integers instead of (more obvious and easier to read) hex values. Switching to char instead of uint8_t resolves the issue.

@abitmore abitmore added this to In Development in Protocol Upgrade Release (3.0.0) via automation Jan 21, 2019

@jmjatlanta jmjatlanta merged commit aaf7701 into hardfork Jan 24, 2019

2 of 3 checks passed

ci/dockercloud Your tests failed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

Protocol Upgrade Release (3.0.0) automation moved this from In Development to Done Jan 24, 2019

@jmjatlanta jmjatlanta deleted the jmj_uint8_switch branch Jan 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.