Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename API param operation_id to operation_type #1544

Merged
merged 1 commit into from Jan 27, 2019

Conversation

Projects
3 participants
@abitmore
Copy link
Member

commented Jan 26, 2019

in order to reduce confusion, because we usually use "operation_type"
to indicate the type of an operation, but use "operation_id" for
operation_history_id_type.

Rename API param operation_id to operation_type
in order to reduce confusion, because we usually use "operation_type"
to indicate the type of an operation, but use "operation_id" for
operation_history_id_type.

@abitmore abitmore added this to the 201902 - Feature Release milestone Jan 26, 2019

@abitmore abitmore added this to In progress in Feature Release (201902) via automation Jan 26, 2019

Feature Release (201902) automation moved this from In progress to In Review Jan 27, 2019

@oxarbitrage
Copy link
Member

left a comment

i agree with this, thanks.

@oxarbitrage oxarbitrage merged commit 893607f into develop Jan 27, 2019

2 of 3 checks passed

ci/dockercloud Your tests failed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

Feature Release (201902) automation moved this from In Review to Done Jan 27, 2019

@abitmore abitmore deleted the op-type branch Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.