Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build simplification #1547

Merged
merged 13 commits into from Jan 31, 2019

Conversation

Projects
3 participants
@pmconrad
Copy link
Contributor

commented Jan 30, 2019

  • Got rid of more boost dependencies
  • Improvements to docker build
  • Improvements to travis build

Includes similar changes in FC, see bitshares/bitshares-fc#104 .

The fc bump comes with a number of additional changes - FC PR's 99-103.

@jmjatlanta
Copy link
Contributor

left a comment

Compiled fine on Ubuntu 18.10 / Boost 1.67 / OpenSSL 1.1

@pmconrad

This comment has been minimized.

Copy link
Contributor Author

commented Jan 30, 2019

Thanks. Waiting to see if Docker build works.

@pmconrad pmconrad dismissed stale reviews from jmjatlanta and abitmore via e1eb934 Jan 30, 2019

@pmconrad

This comment has been minimized.

Copy link
Contributor Author

commented Jan 31, 2019

Docker build now runs into different problem... :-/
db_update.cpp:(.text+0x26733): undefined reference to 'fc::smart_ref<graphene::chain::fee_schedule>::operator*() const'
:-(

@jmjatlanta
Copy link
Contributor

left a comment

Thanks!

@pmconrad pmconrad merged commit 5503152 into develop Jan 31, 2019

2 of 3 checks passed

ci/dockercloud Your tests failed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@pmconrad pmconrad deleted the build_simplification branch Jan 31, 2019

@jmjatlanta jmjatlanta referenced this pull request Jan 31, 2019

Closed

smart_ref causes build issues #1548

1 of 3 tasks complete

@pmconrad pmconrad referenced this pull request Feb 1, 2019

Open

Merge improvements from BitShares #26

4 of 24 tasks complete

@abitmore abitmore added this to In progress in Feature Release (201902) via automation Feb 5, 2019

@abitmore abitmore added this to the 201902 - Feature Release milestone Feb 5, 2019

@jmjatlanta jmjatlanta moved this from In progress to Done in Feature Release (201902) Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.