Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
replace smart_ref with shared_ptr #1556
Potential fix for #1548
The use of fc::smart_ref was to allow for compilation of current_fees while there is a circular reference between fee_schedule, chain_parameters, and operations. But its use is problematic (build errors).
One potential replacement was to switch to unique_ptr. Unfortunately, this does not permit circular references (no copies allowed, full implementation needed for destruction).
shared_ptr will allow circular references. This PR uses shared_ptr to replace fc::smart_ref