Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent oversized transactions #1586

Merged
merged 4 commits into from Feb 19, 2019

Conversation

Projects
3 participants
@jmjatlanta
Copy link
Contributor

commented Feb 14, 2019

Fixes #1573

jmjatlanta added some commits Feb 14, 2019

@jmjatlanta jmjatlanta changed the title Jmj 1573 Prevent oversized transactions Feb 14, 2019

@pmconrad
Copy link
Contributor

left a comment

Please move the pack_size calculation out of the single-threaded code.

@abitmore abitmore added this to In Development in Protocol Upgrade Release (3.0.0) via automation Feb 18, 2019

Protocol Upgrade Release (3.0.0) automation moved this from In Development to In Review Feb 19, 2019

@pmconrad

This comment has been minimized.

Copy link
Contributor

commented Feb 19, 2019

Travis reported one failure in chain_test, worked upon restart. Strange.

@jmjatlanta jmjatlanta merged commit 3846151 into hardfork Feb 19, 2019

3 checks passed

ci/dockercloud Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

Protocol Upgrade Release (3.0.0) automation moved this from In Review to Done Feb 19, 2019

@jmjatlanta jmjatlanta referenced this pull request Feb 22, 2019

Closed

Check transaction size #1573

2 of 17 tasks complete

@abitmore abitmore referenced this pull request Feb 26, 2019

Closed

Skip transaction size check during replay #1619

1 of 17 tasks complete

@abitmore abitmore deleted the jmj_1573 branch Feb 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.