Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use platform agnostic int #1589

Merged
merged 1 commit into from Feb 16, 2019

Conversation

Projects
3 participants
@jmjatlanta
Copy link
Contributor

commented Feb 15, 2019

Fixes #1590

By using size_t there will be a difference in size depending on the platform. macOS uses a different size than linux or Windows.

This fix allows for easier compiling on the macOS platform by avoiding template errors about unsigned long long.

@ryanRfox ryanRfox added this to In Development in Protocol Upgrade Release (3.0.0) via automation Feb 15, 2019

Protocol Upgrade Release (3.0.0) automation moved this from In Development to In Review Feb 15, 2019

@jmjatlanta jmjatlanta merged commit e410a8a into hardfork Feb 16, 2019

1 of 3 checks passed

ci/dockercloud Your tests are pending in Docker Cloud
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Protocol Upgrade Release (3.0.0) automation moved this from In Review to Done Feb 16, 2019

@jmjatlanta jmjatlanta deleted the jmj_mac_sizet branch Feb 16, 2019

@abitmore abitmore referenced this pull request Feb 16, 2019

Closed

Build fails on macOS due to size_t (hardfork branch) #1590

1 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.