Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warnings #1597

Merged
merged 1 commit into from Feb 18, 2019

Conversation

Projects
2 participants
@abitmore
Copy link
Member

commented Feb 16, 2019

This PR will fix these warnings:

/tests/common/database_fixture.cpp: In member function ‘const graphene::chain::call_order_object* graphene::chain::database_fixture::borrow(const graphene::chain::account_object&, graphene::chain::asset, graphene::chain::asset, fc::optional<short unsigned int>)’:
/tests/common/database_fixture.cpp:938:32: warning: ‘*((void*)& update +56)’ may be used uninitialized in this function [-Wmaybe-uninitialized]
    call_order_update_operation update;
                                ^
/tests/common/database_fixture.cpp: In member function ‘void graphene::chain::database_fixture::cover(const graphene::chain::account_object&, graphene::chain::asset, graphene::chain::asset, fc::optional<short unsigned int>)’:
/tests/common/database_fixture.cpp:963:32: warning: ‘*((void*)& update +56)’ may be used uninitialized in this function [-Wmaybe-uninitialized]
    call_order_update_operation update;
                                ^

@abitmore abitmore added this to In Development in Protocol Upgrade Release (3.0.0) via automation Feb 16, 2019

@oxarbitrage

This comment has been minimized.

Copy link
Member

commented Feb 16, 2019

Good, but i think this should be in the develop branch. Why hardfork ?

@abitmore abitmore force-pushed the abitmore-patch-1 branch from ee7874c to 695f34b Feb 18, 2019

@abitmore abitmore changed the base branch from hardfork to develop Feb 18, 2019

@abitmore

This comment has been minimized.

Copy link
Member Author

commented Feb 18, 2019

Rebased to develop branch.

@abitmore abitmore added this to In development in Feature Release (3.1.0) via automation Feb 18, 2019

@abitmore abitmore removed this from In Development in Protocol Upgrade Release (3.0.0) Feb 18, 2019

@abitmore abitmore referenced this pull request Feb 18, 2019

Merged

bump fc #1596

@oxarbitrage oxarbitrage merged commit ad74de4 into develop Feb 18, 2019

1 of 2 checks passed

ci/dockercloud Your tests are pending in Docker Cloud
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

Feature Release (3.1.0) automation moved this from In development to Done Feb 18, 2019

@abitmore abitmore deleted the abitmore-patch-1 branch Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.