Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly improve limit order creation performance #1621

Merged
merged 1 commit into from Feb 27, 2019

Conversation

Projects
2 participants
@abitmore
Copy link
Member

commented Feb 27, 2019

Follow up #1608

@abitmore abitmore added this to In development in Feature Release (3.1.0) via automation Feb 27, 2019

@pmconrad
Copy link
Contributor

left a comment

Not sure if it's worth the trouble. Getting rid of a local variable is probably something the optimizer will do anyway when applicable.

@abitmore

This comment has been minimized.

Copy link
Member Author

commented Feb 27, 2019

This PR saves a DB query (at least looks like it). I'm not sure about the local variable either.

@abitmore abitmore merged commit fe510a2 into develop Feb 27, 2019

1 of 3 checks passed

ci/dockercloud Your tests are pending in Docker Cloud
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Feature Release (3.1.0) automation moved this from In development to Done Feb 27, 2019

@abitmore abitmore deleted the abitmore-patch-1 branch Feb 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.