Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sleep to cli_test #1626

Merged
merged 3 commits into from Mar 4, 2019

Conversation

Projects
2 participants
@abitmore
Copy link
Member

commented Feb 28, 2019

PR for #1303. On my machine, with this patch, cli_test still hangs sometimes, but no longer crashes. More info in the issue.

@abitmore abitmore added this to In development in Feature Release (3.1.0) via automation Feb 28, 2019

abitmore added some commits Feb 28, 2019

@pmconrad
Copy link
Contributor

left a comment

Very good, thanks!

@abitmore abitmore merged commit 458beae into develop Mar 4, 2019

3 checks passed

ci/dockercloud Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

Feature Release (3.1.0) automation moved this from In development to Done Mar 4, 2019

@abitmore abitmore deleted the 1303-cli-test-issues branch Mar 4, 2019

@abitmore abitmore referenced this pull request Jun 4, 2019

Open

Websocket server crashes on quit #1784

1 of 17 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.