Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows Build Errors #1633

Merged
merged 2 commits into from Mar 5, 2019

Conversation

Projects
3 participants
@jmjatlanta
Copy link
Contributor

commented Mar 5, 2019

This is a partial fix for #1593

  1. Evidently recent Boost versions include WinSock.h, which is not protected from being included more than once. The fix is to use the LEAN_AND_MEAN precompiler directive.

  2. The compiler could not determine the way to compare an uint64_t and a safe<int64_t>. The fix is to pull the value from its "safe" wrapper and compare that.

@jmjatlanta jmjatlanta merged commit a328f8c into develop Mar 5, 2019

3 checks passed

ci/dockercloud Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jmjatlanta jmjatlanta deleted the jmj_winbuildfix branch Mar 5, 2019

@abitmore abitmore added this to In development in Feature Release (3.1.0) via automation Mar 6, 2019

@ryanRfox ryanRfox moved this from In development to Done in Feature Release (3.1.0) Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.