Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new commands to CLI: get_transaction_signers, get_key_references #1635

Merged
merged 5 commits into from Mar 27, 2019

Conversation

Projects
3 participants
@OpenLedgerApp
Copy link
Contributor

commented Mar 6, 2019

No description provided.

@pmconrad
Copy link
Contributor

left a comment

Looks good.
Please add test cases in tests/cli/main.cpp.

@abitmore abitmore added this to In development in Feature Release (3.1.0) via automation Mar 6, 2019

OpenLedgerApp and others added some commits Mar 19, 2019

Merge pull request #1 from openledger/issue-1210-core-912
add unit tests for get_signed_transaction_signers, get_key_references
@OpenLedgerApp

This comment has been minimized.

Copy link
Contributor Author

commented Mar 25, 2019

Added test cases

Show resolved Hide resolved tests/cli/main.cpp Outdated
Show resolved Hide resolved tests/cli/main.cpp Outdated
Alexey Frolov

@pmconrad pmconrad merged commit ed08580 into bitshares:develop Mar 27, 2019

2 checks passed

ci/dockercloud Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Feature Release (3.1.0) automation moved this from In development to Done Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.