Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet info() change participation to int #1666

Merged
merged 2 commits into from Mar 24, 2019

Conversation

Projects
3 participants
@oxarbitrage
Copy link
Member

commented Mar 22, 2019

The current response from the info() call in the cli_wallet is: "participation":"100.00000000000000000".

I think such a precision is not needed for this value so this pull changes it to int. Output will be: "participation":100.

Unlikely to break client applications but maybe "participation":"100.0" will be a better option. Open to ideas.

@abitmore

This comment has been minimized.

Copy link
Member

commented Mar 23, 2019

Personally I like 2 decimals.

@abitmore

This comment has been minimized.

Copy link
Member

commented Mar 23, 2019

On that note, perhaps fix the percentages when replaying as well:

2997361ms th_a       db_management.cpp:134         reindex              ]    [by size: 14.56165401658106617%   785109804 of 5391625176]   [by num: 25.05069335144405684%   6390000 of 25508276]
2997472ms th_a       db_management.cpp:134         reindex              ]    [by size: 14.58242697396292442%   786229804 of 5391625176]   [by num: 25.08989631443536084%   6400000 of 25508276]
@pmconrad

This comment has been minimized.

Copy link
Contributor

commented Mar 23, 2019

For replay more than 2 decimals would make sense I think.

@oxarbitrage

This comment has been minimized.

Copy link
Member Author

commented Mar 23, 2019

With the last commit , participation will display as: "participation": "100.00".

If we agree here i will send a separated pull request for replaying, i am thinking on 5 decimals in there.

@abitmore abitmore added this to In development in Protocol Upgrade Release (4.0.0) via automation Mar 23, 2019

@abitmore abitmore added this to In development in Feature Release (3.1.0) via automation Mar 23, 2019

@abitmore abitmore removed this from In development in Protocol Upgrade Release (4.0.0) Mar 23, 2019

@oxarbitrage oxarbitrage merged commit a411589 into develop Mar 24, 2019

3 checks passed

ci/dockercloud Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

Feature Release (3.1.0) automation moved this from In development to Done Mar 24, 2019

@oxarbitrage oxarbitrage deleted the oxarbitrage-patch-1 branch Mar 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.