Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some warnings #1677

merged 1 commit into from Mar 25, 2019


2 participants
Copy link

commented Mar 25, 2019

A sister PReq to bitshares/bitshares-fc#116, fix some warnings in the BitShares repo as well:

  • Add a virtual destructor to peer_connection_delegate to squelch warnings from inheritors that the class has virtual methods, but no virtual destructor
  • A few test sites reference ->id without using it as a shorthand to crash if a newly created object is null, but this causes unused reference warnings, so make the checks explicit instead.

@abitmore abitmore added this to In development in Feature Release (3.1.0) via automation Mar 25, 2019

@nathanhourt nathanhourt merged commit b96cc0c into bitshares:develop Mar 25, 2019

2 checks passed

ci/dockercloud Your tests passed in Docker Cloud
continuous-integration/travis-ci/pr The Travis CI build passed

Feature Release (3.1.0) automation moved this from In development to Done Mar 25, 2019

@nathanhourt nathanhourt deleted the nathanhourt:warnings branch Mar 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.