Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PReq for #1670: Make chain_parameters::current_fees const #1678

Merged
merged 5 commits into from Apr 10, 2019

Conversation

Projects
3 participants
@nathanhourt
Copy link
Contributor

commented Mar 25, 2019

#1670: Make const const again

@nathanhourt nathanhourt referenced this pull request Mar 25, 2019

Closed

Make chain_parameters::current_fees const #1670

2 of 17 tasks complete

@abitmore abitmore changed the title PReq for #1670 PReq for #1670: Make chain_parameters::current_fees const Mar 25, 2019

@abitmore abitmore added this to In development in Feature Release (3.1.0) via automation Mar 25, 2019

@pmconrad

This comment has been minimized.

Copy link
Contributor

commented Apr 3, 2019

Looks good.

@pmconrad

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

Doesn't compile with latest develop, it seems. Please check.

nathanhourt added some commits Mar 23, 2019

Ref #1670: Rename non-const getter for clarity
Rename non-const `get_current_fees()` to `get_mutable_fees()` to
make its non-constness explicit at the call site

@nathanhourt nathanhourt force-pushed the nathanhourt:issue-1670 branch from 23a4d5e to 94e3aac Apr 9, 2019

@pmconrad pmconrad merged commit e44cd00 into bitshares:develop Apr 10, 2019

2 checks passed

ci/dockercloud Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Feature Release (3.1.0) automation moved this from In development to Done Apr 10, 2019

@nathanhourt nathanhourt deleted the nathanhourt:issue-1670 branch Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.