Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation to HTLC Extend #1699

Merged
merged 6 commits into from Apr 8, 2019

Conversation

Projects
None yet
3 participants
@jmjatlanta
Copy link
Contributor

commented Apr 4, 2019

Fixes #1696

jmjatlanta added some commits Apr 4, 2019

@jmjatlanta jmjatlanta referenced this pull request Apr 4, 2019

Closed

Insufficient htlc_extend_operation validation #1696

2 of 17 tasks complete

jmjatlanta added some commits Apr 4, 2019


account_id_type fee_payer()const { return to; }
void validate()const { FC_ASSERT( !"virtual operation" ); }

share_type calculate_fee(const fee_parameters_type& k)const { return 0; }

htlc_id_type htlc_id;
account_id_type from, to;
account_id_type from, to, redeemer;

This comment has been minimized.

Copy link
@abitmore

abitmore Apr 5, 2019

Member

I think we need to bump DB_VERSION if to add a field here.

This comment has been minimized.

Copy link
@jmjatlanta

jmjatlanta Apr 5, 2019

Author Contributor

Done.

This comment has been minimized.

Copy link
@pmconrad

pmconrad Apr 6, 2019

Contributor

I disagree. We don't have any such operations in the database yet, therefore the change has no effect. We can avoid the replay.
(If you agree please drop the last two commits and force-push instead of reverting.)

This comment has been minimized.

Copy link
@abitmore

abitmore Apr 7, 2019

Member

We can do the bump for testnet branch only.

This comment has been minimized.

Copy link
@jmjatlanta

jmjatlanta Apr 8, 2019

Author Contributor

Done

@jmjatlanta jmjatlanta force-pushed the jmj_htlc_hotfix branch from bd7634e to 8f5dddd Apr 8, 2019

@pmconrad
Copy link
Contributor

left a comment

Thanks!

@jmjatlanta jmjatlanta merged commit ac9bcfb into release Apr 8, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jmjatlanta jmjatlanta deleted the jmj_htlc_hotfix branch Apr 8, 2019

@abitmore abitmore added this to the 3.0.1 - hotfix milestone Apr 8, 2019

@jmjatlanta jmjatlanta referenced this pull request Apr 8, 2019

Closed

Release notes for 3.0.1 #1711

@bitfag bitfag referenced this pull request Apr 25, 2019

Open

HTLC support #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.