Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the serializer to fix #1701 #1702

Merged
merged 2 commits into from Apr 29, 2019

Conversation

Projects
3 participants
@xeroc
Copy link
Member

commented Apr 5, 2019

Improves the serializer to match the output used in bitsharesjs these days.

xeroc added some commits Apr 5, 2019

@abitmore abitmore added this to In development in Feature Release (3.1.0) via automation Apr 8, 2019

@abitmore abitmore added this to the 3.1.0 - Feature Release milestone Apr 8, 2019

@pmconrad

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

Merging since it's a step in the right direction. Suggest to keep #1701 open for further improvements.

@pmconrad pmconrad merged commit febebff into develop Apr 29, 2019

3 checks passed

ci/dockercloud Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

Feature Release (3.1.0) automation moved this from In development to Done Apr 29, 2019

@pmconrad pmconrad deleted the 1701-improve-serializer branch Apr 29, 2019

@pmconrad

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

Merging this has introduced a regression - it uses fc::smart_ref which no longer exists. Working on a fix.

pmconrad added a commit to pmconrad/bitshares-core that referenced this pull request Apr 29, 2019

jmjatlanta added a commit that referenced this pull request Apr 29, 2019

Merge pull request #1741 from pmconrad/1702_regression
Fixed regression in #1702 - removed obsolete smart_ref

@pmconrad pmconrad referenced this pull request Apr 30, 2019

Open

js_operation_serializer outdates #1701

4 of 17 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.