Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install debug_witness headers #1727

Merged
merged 1 commit into from Apr 29, 2019

Conversation

Projects
5 participants
@xloem
Copy link
Contributor

commented Apr 21, 2019

Adds debug_witness headers to installation.

These headers were not installed, but are used by other header files that are installed.

@pmconrad
Copy link
Contributor

left a comment

Thanks.

Question is, why would anyone want to install our headers at all? It's not like we're offereing general-purpose libraries or similar. Is anyone building C++ applications based on our code?

@abitmore abitmore added this to the 3.1.0 - Feature Release milestone Apr 23, 2019

@abitmore abitmore added this to In development in Feature Release (3.1.0) via automation Apr 23, 2019

@ryanRfox ryanRfox closed this Apr 23, 2019

Feature Release (3.1.0) automation moved this from In development to Done Apr 23, 2019

@jmjatlanta

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

Reopening

@jmjatlanta jmjatlanta reopened this Apr 23, 2019

Feature Release (3.1.0) automation moved this from Done to In development Apr 23, 2019

@abitmore

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

Need to rebase to develop branch

@abitmore
Copy link
Member

left a comment

Need to rebase to develop branch

@xloem xloem force-pushed the xloem:debug-header-install branch from 583b2c5 to 8cbd15a Apr 23, 2019

@xloem

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

@abitmore I've rebased.

@pmconrad I was looking into what would be needed to use the libraries and headers to make a bitshares wallet app. The codebase appears highly conducive to this.

@xloem xloem changed the base branch from master to develop Apr 23, 2019

Fixed

@pmconrad pmconrad merged commit f1ce877 into bitshares:develop Apr 29, 2019

2 checks passed

ci/dockercloud Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Feature Release (3.1.0) automation moved this from In development to Done Apr 29, 2019

@pmconrad

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.