Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CLI register_account and create_account_with_private_key commands, remove duplicate code #1811

Conversation

@crypto-ape
Copy link
Contributor

commented Jun 20, 2019

Hey Monkeys!

This change refactors an in-place constant used multiple times into a proper constant variable.

Ape out!

libraries/wallet/wallet.cpp Outdated Show resolved Hide resolved
libraries/wallet/wallet.cpp Outdated Show resolved Hide resolved
libraries/wallet/wallet.cpp Outdated Show resolved Hide resolved

@pmconrad pmconrad added this to the 3.3.0 - Feature Release milestone Jun 21, 2019

@pmconrad pmconrad added this to In development in Feature Release (3.3.0) via automation Jun 21, 2019

@crypto-ape crypto-ape force-pushed the crypto-ape:cli_wallet-transaction_default_expiration_as_constant branch from 3ee7209 to 8389cbc Jun 25, 2019

@crypto-ape

This comment has been minimized.

Copy link
Contributor Author

commented Jun 25, 2019

Refactored. Bump.

@abitmore

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

@crypto-ape please rebase to latest develop branch, thanks.

@crypto-ape crypto-ape force-pushed the crypto-ape:cli_wallet-transaction_default_expiration_as_constant branch from 8389cbc to 649709f Jun 26, 2019

@crypto-ape

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

Done.

@pmconrad pmconrad merged commit 416458f into bitshares:develop Jun 27, 2019

2 checks passed

ci/dockercloud Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Feature Release (3.3.0) automation moved this from In development to Done Jun 27, 2019

@abitmore abitmore changed the title cli wallet transaction default expiration as constant Refactor CLI register_account and create_account_with_private_key commands, remove duplicate code Aug 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5 participants
You can’t perform that action at this time.