Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep track of collateral #1836

Merged
merged 10 commits into from Jul 29, 2019

Conversation

@pmconrad
Copy link
Contributor

commented Jun 29, 2019

Resolves #1089
Resolves #1781

Note: the implementation via secondary index has the downside that subscriptions to asset objects will not get notified whenever the tracked values change. There is a precedent in wallet_api: vesting_balance_object_with_info also contains additional values where changes are ignored on subscriptions.

Note 2: the mechanism applied here, i. e. add the secondary indexes after replay, could be used on other indexes as well, which would help speed up replay. See discussion in #452 for example.

@pmconrad pmconrad added this to the 3.3.0 - Feature Release milestone Jun 29, 2019

@pmconrad pmconrad added this to In development in Feature Release (3.3.0) via automation Jun 29, 2019

@abitmore

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

Enable the new plugin by default?

@pmconrad

This comment has been minimized.

Copy link
Contributor Author

commented Jul 1, 2019

Good idea. Still should highlight this in the release notes.

@jmjatlanta
Copy link
Contributor

left a comment

Code looks good. Tests run fine and are complete. Tested on macOS 10.14 / Boost 1.69. Good job.

@ryanRfox ryanRfox moved this from In development to In testing in Feature Release (3.3.0) Jul 16, 2019

@oxarbitrage oxarbitrage self-requested a review Jul 22, 2019

@pmconrad pmconrad merged commit 2b5d3d0 into bitshares:develop Jul 29, 2019

2 checks passed

ci/dockercloud Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Feature Release (3.3.0) automation moved this from In testing to Done Jul 29, 2019

@pmconrad pmconrad deleted the pmconrad:1089_asset_in_collateral branch Jul 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.