Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional subscribe param to some database APIs #1868

Merged
merged 5 commits into from Aug 14, 2019

Conversation

@abitmore
Copy link
Member

commented Jul 24, 2019

PR for #1819.

These APIs are updated:

  • added a subscribe parameter with type optional<bool>
    • get_objects ( vector ids, optional<bool> subscribe )
    • get_assets ( vector symbols_or_ids, optional<bool> subscribe )
    • get_accounts ( vector names_or_ids, optional<bool> subscribe )
    • lookup_accounts ( string lower_bound, int limit, optional<bool> subscribe )
    • get_htlc ( htlc_id id, optional<bool> subscribe )
  • changed type of subscribe parameter to optional<bool>
    • get_full_accounts ( vector names_or_ids, optional<bool> subscribe )
* @param subscribe @a true to subscribe to the queried objects;
*                  @a false to not subscribe;
*                  @a omit or null to subscribe or not subscribe according to current
*                     auto-subscription setting (see @ref set_auto_subscription)

@abitmore abitmore added this to the 3.3.0 - Feature Release milestone Jul 24, 2019

@abitmore abitmore added this to In development in Feature Release (3.3.0) via automation Jul 24, 2019

@abitmore abitmore force-pushed the pr-1819-subscription branch from 2116906 to d854564 Jul 25, 2019

@abitmore abitmore changed the base branch from update-api-docs to develop Jul 25, 2019

@jmjatlanta jmjatlanta added this to In testing in Feature Release (4.1.0) via automation Aug 7, 2019

@jmjatlanta jmjatlanta removed this from In development in Feature Release (3.3.0) Aug 7, 2019

@abitmore abitmore marked this pull request as ready for review Aug 8, 2019

@abitmore

This comment has been minimized.

Copy link
Member Author

commented Aug 8, 2019

Added test cases. This PR is now ready for review.

abitmore added 4 commits Jul 24, 2019
Add optional subscribe param to some database APIs
These APIs are updated:
- get_objects
- get_assets
- get_accounts
- get_full_accounts
- lookup_accounts
- get_htlc

@abitmore abitmore force-pushed the pr-1819-subscription branch from 83e5f86 to 8d0e860 Aug 8, 2019

@abitmore abitmore added this to In development in Feature Release (3.3.0) via automation Aug 8, 2019

@abitmore abitmore removed this from In testing in Feature Release (4.1.0) Aug 8, 2019

@abitmore

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2019

@sschiessl-bcp and @startailcoon: you may have interest.

libraries/app/database_api.cpp Show resolved Hide resolved
libraries/app/database_api.cpp Outdated Show resolved Hide resolved
libraries/app/database_api.cpp Outdated Show resolved Hide resolved
libraries/app/include/graphene/app/database_api.hpp Outdated Show resolved Hide resolved

@abitmore abitmore force-pushed the pr-1819-subscription branch from 272f69b to ebd5dbb Aug 13, 2019

Feature Release (3.3.0) automation moved this from In development to In testing Aug 14, 2019

@oxarbitrage oxarbitrage merged commit f87858c into develop Aug 14, 2019

3 checks passed

ci/dockercloud Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

Feature Release (3.3.0) automation moved this from In testing to Done Aug 14, 2019

@oxarbitrage oxarbitrage referenced this pull request Aug 14, 2019
1 of 8 tasks complete

@abitmore abitmore deleted the pr-1819-subscription branch Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.