Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sign_message command to cli_wallet #1878

Merged
merged 8 commits into from Aug 7, 2019
Merged

Conversation

pmconrad
Copy link
Contributor

@pmconrad pmconrad commented Aug 2, 2019

Adds a command to sign a message using an account's memo key, as implemented in https://github.com/xeroc/python-graphenelib/blob/d9634d74273ebacc92555499eca7c444217ecba0/graphenecommon/message.py#L64 .
Also allows verifying such signatures.

Such messages can be used for authentication purposes, an example is https://workers.bitshares.foundation/ .

Note: a formal specification for such signatures is in the works. The current draft of that specification is similar to the mechanism used here, but is not 100% compatible.

@pmconrad pmconrad added this to the 3.3.0 - Feature Release milestone Aug 2, 2019
@pmconrad pmconrad added this to In development in Feature Release (3.3.0) via automation Aug 2, 2019
@abitmore
Copy link
Member

abitmore commented Aug 2, 2019

libraries/wallet/wallet.cpp Outdated Show resolved Hide resolved
libraries/wallet/wallet.cpp Outdated Show resolved Hide resolved
libraries/wallet/wallet.cpp Show resolved Hide resolved
tests/cli/main.cpp Show resolved Hide resolved
@pmconrad
Copy link
Contributor Author

pmconrad commented Aug 5, 2019

Is this compatible? https://wallet.bitshares.org/#/account/committee-account/signedmessages

Should be now, after accepting string-formatted time.

Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. Waiting for Travis.

@pmconrad pmconrad merged commit fc1c972 into bitshares:develop Aug 7, 2019
Feature Release (3.3.0) automation moved this from In development to Done Aug 7, 2019
@pmconrad pmconrad deleted the sign_msg branch August 7, 2019 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants