Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `sign_message` command to `cli_wallet` #1878

Merged
merged 8 commits into from Aug 7, 2019

Conversation

@pmconrad
Copy link
Contributor

commented Aug 2, 2019

Adds a command to sign a message using an account's memo key, as implemented in https://github.com/xeroc/python-graphenelib/blob/d9634d74273ebacc92555499eca7c444217ecba0/graphenecommon/message.py#L64 .
Also allows verifying such signatures.

Such messages can be used for authentication purposes, an example is https://workers.bitshares.foundation/ .

Note: a formal specification for such signatures is in the works. The current draft of that specification is similar to the mechanism used here, but is not 100% compatible.

@pmconrad pmconrad added this to the 3.3.0 - Feature Release milestone Aug 2, 2019

@pmconrad pmconrad added this to In development in Feature Release (3.3.0) via automation Aug 2, 2019

@abitmore

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

libraries/wallet/wallet.cpp Outdated Show resolved Hide resolved
libraries/wallet/wallet.cpp Outdated Show resolved Hide resolved
libraries/wallet/wallet.cpp Show resolved Hide resolved
tests/cli/main.cpp Show resolved Hide resolved
@pmconrad

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

Is this compatible? https://wallet.bitshares.org/#/account/committee-account/signedmessages

Should be now, after accepting string-formatted time.

@abitmore
Copy link
Member

left a comment

Looks good, thanks. Waiting for Travis.

@pmconrad pmconrad merged commit fc1c972 into bitshares:develop Aug 7, 2019

2 checks passed

ci/dockercloud Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Feature Release (3.3.0) automation moved this from In development to Done Aug 7, 2019

@pmconrad pmconrad deleted the pmconrad:sign_msg branch Aug 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.