Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix market ticker volume underflow issue #1885

Merged
merged 2 commits into from Aug 8, 2019

Conversation

@abitmore
Copy link
Member

commented Aug 6, 2019

PR for #1883.

@abitmore abitmore added this to the 3.3.0 - Feature Release milestone Aug 6, 2019

@abitmore abitmore added this to In development in Feature Release (3.3.0) via automation Aug 6, 2019

@abitmore abitmore moved this from In development to In testing in Feature Release (3.3.0) Aug 6, 2019

@abitmore abitmore referenced this pull request Aug 6, 2019
1 of 17 tasks complete

@ryanRfox ryanRfox requested review from jmjatlanta and oxarbitrage Aug 7, 2019

@oxarbitrage
Copy link
Member

left a comment

looks good @abitmore . thank you.

@jmjatlanta
Copy link
Contributor

left a comment

Nicely found, nicely fixed. Thanks!

@oxarbitrage oxarbitrage merged commit 90fd510 into develop Aug 8, 2019

3 checks passed

ci/dockercloud Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

Feature Release (3.3.0) automation moved this from In testing to Done Aug 8, 2019

@abitmore abitmore deleted the pr-1883-fix-ticker-rolling branch Aug 14, 2019

abitmore added a commit that referenced this pull request Aug 18, 2019
Bump DB_VERSION
Due to #1885, need to force a replay.
This was referenced Aug 18, 2019
jmjatlanta added a commit that referenced this pull request Sep 3, 2019
Bump DB_VERSION
Due to #1885, need to force a replay.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.