Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Database_api code refactory #1891
Putting this in 3.3 release so far, please feel free to move out if it's not appropriate.
Nice stuff, in the right direction.
For continuation in new lines of functions with arguments i personally prefer to use double indentation(6 spaces in our codebase) as sometimes the namespace, type, name, etc can be so long that you will have little space to place the arguments if you place them one below the other aligned. I see you applied some of that in some cases(where you didn't had another option) with more than 6 spaces. 6 spaces will kind of work always, if more then 2 lines are needed i do something like: