Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows linker error #1920

Merged
merged 1 commit into from Aug 15, 2019

Conversation

@abitmore
Copy link
Member

commented Aug 15, 2019

The error was introduced by #1891.

graphene_app.lib(database_api.obj) : error LNK2019: unresolved external symbol "class std::basic_string<char,struct std::char_traits,class std::allocator > __cdecl graphene::app::price_to_string(struct graphene::protocol::price const &,class graphene::chain::asset_object const &,class graphene::chain::asset_object const &)" (?price_to_string@app@graphene@@ya?AV?$basic_string@DU?$char_traits@D@std@@v?$allocator@D@2@@std@@AEBUprice@protocol@2@AEBVasset_object@chain@2@1@Z) referenced in function "public: struct graphene::app::order_book __cdecl graphene::app::database_api_impl::get_order_book(class std::basic_string<char,struct std::char_traits,class std::allocator > const &,class std::basic_string<char,struct std::char_traits,class std::allocator > const &,unsigned int)const " (?get_order_book@database_api_impl@app@graphene@@qeba?AUorder_book@23@AEBV?$basic_string@DU?$char_traits@D@std@@v?$allocator@D@2@@std@@0i@Z)
3>graphene_app.lib(api_objects.obj) : error LNK2001: unresolved external symbol "class std::basic_string<char,struct std::char_traits,class std::allocator > __cdecl graphene::app::price_to_string(struct graphene::protocol::price const &,class graphene::chain::asset_object const &,class graphene::chain::asset_object const &)" (?price_to_string@app@graphene@@ya?AV?$basic_string@DU?$char_traits@D@std@@v?$allocator@D@2@@std@@AEBUprice@protocol@2@AEBVasset_object@chain@2@1@Z)
3>C:\Development\cpp\bitshares-core-develop\build\tests\generate_empty_blocks\Release\generate_empty_blocks.exe : fatal error LNK1120: 1 unresolved externals

@abitmore abitmore added this to the 3.3.0 - Feature Release milestone Aug 15, 2019

@abitmore abitmore added this to In development in Feature Release (3.3.0) via automation Aug 15, 2019

Feature Release (3.3.0) automation moved this from In development to In testing Aug 15, 2019

@jmjatlanta
Copy link
Contributor

left a comment

Everything now compiles with MSVC 2019 / Boost 1.70. chain_test runs without errors.

@jmjatlanta jmjatlanta merged commit 96e3177 into develop Aug 15, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

Feature Release (3.3.0) automation moved this from In testing to Done Aug 15, 2019

@jmjatlanta jmjatlanta deleted the abitmore-patch-1 branch Aug 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.