Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pthread fix for mac #1927

Merged
merged 1 commit into from Aug 16, 2019

Conversation

@jmjatlanta
Copy link
Contributor

commented Aug 16, 2019

This will help the 3.3.0 release compile on macOS.

@jmjatlanta jmjatlanta referenced this pull request Aug 16, 2019
@jmjatlanta

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

Interestingly, removing the RELRO checks also eliminates the issue. I believe such checks are necessary on some platforms, so we can't remove them. But why this causes pthread.h to not be found is a mystery. This PR fixes the problem. An ideal fix can come later.

@oxarbitrage
Copy link
Member

left a comment

thank you @jmjatlanta

@jmjatlanta

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

I found the issue. The CMakeLists.txt file is modifying the CMAKE_REQUIRED_FLAGS variable and not resetting it. Resetting the variable allows pthread.h to be found.

@jmjatlanta jmjatlanta merged commit 4d246b5 into release Aug 16, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@pmconrad pmconrad deleted the jmj_macfix branch Aug 16, 2019

@abitmore abitmore added this to the 3.3.0 - Feature Release milestone Aug 16, 2019

@abitmore abitmore added this to In development in Feature Release (3.3.0) via automation Aug 16, 2019

@abitmore abitmore moved this from In development to Done in Feature Release (3.3.0) Aug 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.