Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove verify_account_history_plugin_index() #915

Merged
merged 1 commit into from Aug 17, 2018

Conversation

Projects
5 participants
@oxarbitrage
Copy link
Member

commented May 11, 2018

function verify_account_history_plugin_index() in the test cases do return immediately after it is called, ignoring the body on it fully. haves no sense to keep or use IMO(maybe i am missing something), this PR remove function and calls to it.

@abitmore

This comment has been minimized.

Copy link
Member

commented May 12, 2018

I think we need to fix it rather than removing it. Maybe add similar tests for other plugins.

@ryanRfox ryanRfox added this to To Do in Feature Release (201808) via automation Jun 13, 2018

@ryanRfox ryanRfox added this to In Development in Protocol Upgrade Release (3.0.0) Jun 13, 2018

@ryanRfox

This comment has been minimized.

Copy link
Member

commented Jun 13, 2018

I believe this is a Protocol Impacting Issue. If so, may I request @oxarbitrage @abitmore to Label it and place it on the proper Release (remove the incorrect one, as I assigned it to both).

@oxarbitrage

This comment has been minimized.

Copy link
Member Author

commented Jun 13, 2018

not protocol update here. what happens is that the code in question is not active in the moment so i removed it. @abitmore think the code should be fixed instead of removed. I didn't had the time to take a look on how hard to fix it yet however this is something we probably can do in the next release.

@ryanRfox ryanRfox removed this from In Development in Protocol Upgrade Release (3.0.0) Jun 14, 2018

@ryanRfox

This comment has been minimized.

Copy link
Member

commented Jun 14, 2018

@oxarbitrage Thanks for clarifying the Release placement. May I request you add the reference to the Issue number? I am unable to locate an Issue this fixes.

@oxarbitrage

This comment has been minimized.

Copy link
Member Author

commented Jun 14, 2018

there is no issue for this, just the pull at the moment.

@abitmore abitmore moved this from To Do to In Development in Feature Release (201808) Jun 25, 2018

@abitmore abitmore added the testing label Jun 25, 2018

@abitmore abitmore removed this from In Development in Feature Release (201808) Jul 21, 2018

@abitmore abitmore added this to New -Awaiting Core Team Evaluation in Project Backlog via automation Jul 21, 2018

@cogutvalera

This comment has been minimized.

Copy link
Member

commented Aug 14, 2018

maybe we should create issue for this PR ?

@pmconrad
Copy link
Contributor

left a comment

AFAICS the commented-out code checks some mapping of accounts to addresses.
That doesn't make sense at all, so I don't see how this could be fixed, therefore I approve removal.
(Feel free to disagree ofc.)

@abitmore

This comment has been minimized.

Copy link
Member

commented Aug 17, 2018

I agree. The last related commit is this: a0765e2, which removed a lot of code but left some commented out. According to changes and the commit comment, the commented out code doesn't make sense any more.

@abitmore abitmore removed this from New -Awaiting Core Team Evaluation in Project Backlog Aug 17, 2018

@abitmore abitmore added this to In progress in Feature release (201810) via automation Aug 17, 2018

@abitmore abitmore merged commit fcf42b2 into bitshares:develop Aug 17, 2018

2 checks passed

ci/dockercloud Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Feature release (201810) automation moved this from In progress to Done Aug 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.