Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary asserts #103

Merged
merged 3 commits into from Jan 22, 2019

Conversation

2 participants
@jmjatlanta
Copy link

commented Jan 18, 2019

This is part of issue bitshares/bitshares-core#995

Originally, it was proposed to be a bit more granular in calculating maximum allocations sizes for array-like containers. Such a change must be careful to not break consensus.

A subsequent change (see #100) protects nodes from large transactions entering from the network, thereby minimizing or eliminating the need for checks in those unpacking routines.

This pull removes those checks.

Related: #55

Show resolved Hide resolved include/fc/io/raw.hpp Outdated

jmjatlanta added some commits Jan 21, 2019

@pmconrad
Copy link

left a comment

Thanks!

@jmjatlanta jmjatlanta merged commit 87260fe into master Jan 22, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jmjatlanta jmjatlanta deleted the jmj_995 branch Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.