Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow zlib to be optional #110

Merged
merged 1 commit into from Mar 4, 2019

Conversation

3 participants
@jmjatlanta
Copy link

commented Feb 26, 2019

permessage_deflate was added assuming zlib will always be available. This change allows compilation without zlib.

Part of bitshares/bitshares-core#1593

@pmconrad
Copy link

left a comment

Looks reasonable. Can't test without zlib though.

@abitmore

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

Should we initialize HAS_ZLIB in CMake file, or it's already done?

@jmjatlanta

This comment has been minimized.

Copy link
Author

commented Feb 27, 2019

Should we initialize HAS_ZLIB in CMake file, or it's already done?

Already there. See

add_definitions( -DHAS_ZLIB )

I am now questioning the negotiation between nodes with one enabled and another disabled. I will hold off on merging this until I feel a bit better about it.

@pmconrad

This comment has been minimized.

Copy link

commented Feb 27, 2019

Nodes do not interact via websocket.

Not quite true, delayed_node connects to its trusted_node via WS-RPC. It uses the same methods as cli_wallet though.

@pmconrad

This comment has been minimized.

Copy link

commented Mar 1, 2019

Tested server versions with {no,enabled} per_message_deflate against cli_wallet with {no,enabled,disabled} per_message_deflate.
Observed with wireshark that messages are compressed only when both are enabled, uncompressed in all other cases.

@jmjatlanta jmjatlanta merged commit 6a5ba93 into master Mar 4, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@abitmore abitmore deleted the jmj_zlib branch May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.